Re: svn commit: rev 259 - trunk/subversion/libsvn_ra_dav

Greg Stein <gstein@lyra.org> writes:

> The *problem* is that set_prop takes an svn_stringbuf_t. It has absolutely
> no need to do that since it isn't going to change the contents. That is
> exactly what the bitch in my comment said.

I know, I know!

I literally spent *two hours* trying to make the prop callbacks take
const svn_string_t's. But the change kept exploding -- it became
exponentially complex. I wasn't able to keep track anymore -- the
fingers of the change spread out into nearly every function in
libsvn_wc. It was horrible.

So, after two hours, I bailed. But I saved my patch-in-progress (and
the log). I'll file a task about it. Somebody's going to have to
spend all day doing this. At this point, I believe the task is
inextricable from doing a "general" const-ifying cleanup of all of
libsvn_wc. Really huge.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:45 2006