[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: recursion in ensure_uniform_revisions

From: Kevin Pilch-Bisson <kevin_at_pilch-bisson.net>
Date: 2001-10-18 19:53:51 CEST

On Thu, Oct 18, 2001 at 12:45:36PM -0500, Ben Collins-Sussman wrote:
> Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
>
> The update editor's close_directory() schedules *changed* items to be
> revision-bumped. If the action was an update (and not a checkout),
> then ensure_uniform_revision() makes sure everything else was bumped.
>
> The way to implement the --nonrecursive flag for updates:
>
> * add a nonrecursive flag to the edit_baton, as you've done.

Done.

>
> * if the editor receives a change that is *below* the editor's
> 'target', and nonrecursive is set, then ignore the change.

Well I did this part a little differently. I actually pass the recurse arg
all the way through the reporter to svn_repos_dir_delta. That way, we only
tell the server about immediate children, and the server only tells us about
immediate children.

It means a much bigger change(although I am done now), but I think it is the
cleaner solution. It has the side benefit of also working for status, so that
we don't have to filter the responses from the server (but I haven't removed
that part yet).

>
> * give ensure_uniform_revision a nonrecursive option too; if
> edit_baton->nonrecursive is set, you'll want to tell
> ensure_uniform_revision as well.

Done.

-- 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson                    http://www.pilch-bisson.net
     "Historically speaking, the presences of wheels in Unix
     has never precluded their reinvention." - Larry Wall
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

  • application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:45 2006

This is an archived mail posted to the Subversion Dev mailing list.