Re: recursion in ensure_uniform_revisions

Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:

> Just wanted to check something with you all.
> ensure_uniform_revision curre= ntly recurses into subdirs to make
> them all uniform. As part of implementing update --nonrecursive, I
> needed to add a recurse member to edit_baton, so t= hat it wouldn't
> always run recursively. Then I realized that in close_director= y,
> we already schedule the revisions to be bumped, so I thought that
> maybe=20 ensure_uniform_revision never needs to be recursive.

The update editor's close_directory() schedules *changed* items to be
revision-bumped. If the action was an update (and not a checkout),
then ensure_uniform_revision() makes sure everything else was bumped.

The way to implement the --nonrecursive flag for updates:

   * add a nonrecursive flag to the edit_baton, as you've done.
 
   * if the editor receives a change that is *below* the editor's
     'target', and nonrecursive is set, then ignore the change.

   * give ensure_uniform_revision a nonrecursive option too; if
     edit_baton->nonrecursive is set, you'll want to tell
     ensure_uniform_revision as well.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:45 2006