RE: Compile warnings on Win32

There also seems to be a bug in commit.c for Win32.
Here is a temporary fix for import_dir in commit.c
  for (apr_err = apr_dir_read (&this_entry, APR_FINFO_NORM, dir);
       //APR_STATUS_IS_SUCCESS (apr_err); //mpg
                apr_err != 22518; // no more files
       apr_err = apr_dir_read (&this_entry, APR_FINFO_NORM, dir))

I first noticed this in Apache 2.16, but it seems to be fixed in the
recent Apache builds. The problem is related to the fact that
APR_FINFO_DEV | APR_FINFO_INODE (0x3000) is not being cleared in
win32/filestat.c:more_finfo. I was hoping using the latest apr libs
would fix the problem in subversion, but it did not -- leading me to
think the problem is application related.

WRT compiler warnings, you can avoid them at compile time with
#pragma warning( disable : 4244 )

--Mike

-----Original Message-----
From: Branko Cibej [mailto:brane@xbc.nu]
Sent: Wednesday, October 10, 2001 1:31 PM
To: dev@subversion.tigris.org
Subject: Compile warnings on Win32

Just FYI,

There are 5 remaining warnings in the Win32 build, all of which are
caused by apr_off_t being a 64-bit type:

C:\Home\brane\src\svn\repo\subversion\libsvn_fs\reps-strings.c(419) :
warning C4244: 'function' : conversion from '__int64 ' to 'unsigned int
', possible loss of data
C:\Home\brane\src\svn\repo\subversion\libsvn_fs\strings-table.c(77) :
warning C4244: '=' : conversion from '__int64 ' to 'unsigned int ',
possible loss of data
C:\Home\brane\src\svn\repo\subversion\libsvn_delta\svndiff.c(83) :
warning C4244: '=' : conversion from '__int64 ' to 'char ', possible
loss of data
C:\Home\brane\src\svn\repo\subversion\libsvn_delta\text_delta.c(142) :
warning C4244: 'function' : conversion from '__int64 ' to 'const
unsigned int ', possible loss of data
C:\Home\brane\src\svn\repo\subversion\libsvn_wc\adm_ops.c(800) : warning
C4244: 'function' : conversion from 'unsigned __int64 ' to 'unsigned
short ', possible loss of data

None of these look particluarly dangerous. If anybody has ideas about
how to avoid them (without casts, if you please :-), I'd be much
obliged. Otherwise I guess we can live with them for now.

-- 
Brane Čibej   <brane_at_xbc.nu>            http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org