On Fri, Oct 05, 2001 at 11:02:16AM -0700, Mo DeJong wrote:
>...
> That said, there was a portion of your previous patch that I
> did deliberately leave out, but you seem to have added anyway.
> The following change in configure.in is incorrect.
>
> --- OLD/trunk/configure.in Fri Oct 5 06:04:23 2001
> +++ NEW/trunk/configure.in Fri Oct 5 06:04:23 2001
> @@ -120,6 +124,10 @@
> else
> args="--disable-shared"
> fi
> +
> + # neon uses an old autoconf which does not understand the -C and
> + # --config-cache arguments. strip them from the args passed down.
> + ac_configure_args="`echo $ac_configure_args | sed 's/-C//' | sed 's/--config-cache//'`"
> APR_SUBDIR_CONFIG(neon, $args --with-expat="$abs_srcdir/expat-lite/libexpat.la")
>
> AC_MSG_CHECKING([for any extra libraries neon needs])
>
>
> The above change would have been needed with neon 1.15.3. We
> now use 1.17.0 and run the neon/autogen.sh in subversion's autogen.sh,
> so it is no longer needed.
Per my log message, the above code *is* still needed unless/until Joe will
be guaranteeing that Neon is distributed using Autoconf 2.50 or later.
If somebody downloads an SVN tarball, then fetchs Neon, and then runs
"./configure" ... the Neon configure will *not* have been rebuilt using
autoconf 2.50. The user did not run any autogen.sh scripts.
If we happen to distribute Neon bundled into our tarball, then it is
possible for us to ensure it is regenerated, but (IMO) that would be
badness. We shouldn't bundle it into our tarball. Most distributors won't be
doing that, but will try to reference a system-installed Neon. Or (like now)
just ask people to download separately.
So... the above check is still needed until we hear from Joe on his plans to
move to autoconf 2.5x.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:44 2006