[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: more autoconf patch questions, for Mo DeJong again

From: Mo DeJong <supermo_at_bayarea.net>
Date: 2001-10-05 20:02:16 CEST

On Thu, 4 Oct 2001 20:20:08 -0700
Greg Stein <gstein@lyra.org> wrote:

...
 
> Sigh.
>
> That was in the patch that I posted. But it used $(abs_srcdir) rather than
> creating yet another variable (full_top_srcdir).
>
> I'll combine Mo's patch with my own and apply tonite. These little bits in
> Mo's patches are annoying me, and I consider them to be rather sloppy.

I certainly did not mean to offend you by deliberately leaving out
a portion of your patch. It is more likely that I simply did not
understand the need for that particular change and for that
reason it did not get moved from my primary tree to a testing
tree before I created the patch. It worked in my configuration
so I was unaware that there was a problem.

That said, there was a portion of your previous patch that I
did deliberately leave out, but you seem to have added anyway.
The following change in configure.in is incorrect.

--- OLD/trunk/configure.in Fri Oct 5 06:04:23 2001
+++ NEW/trunk/configure.in Fri Oct 5 06:04:23 2001
@@ -120,6 +124,10 @@
   else
      args="--disable-shared"
   fi
+
+ # neon uses an old autoconf which does not understand the -C and
+ # --config-cache arguments. strip them from the args passed down.
+ ac_configure_args="`echo $ac_configure_args | sed 's/-C//' | sed 's/--config-cache//'`"
   APR_SUBDIR_CONFIG(neon, $args --with-expat="$abs_srcdir/expat-lite/libexpat.la")

   AC_MSG_CHECKING([for any extra libraries neon needs])

The above change would have been needed with neon 1.15.3. We
now use 1.17.0 and run the neon/autogen.sh in subversion's autogen.sh,
so it is no longer needed.

cheers
Mo DeJong

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:44 2006

This is an archived mail posted to the Subversion Dev mailing list.