[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] libsvn_client/status.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-09-24 21:01:00 CEST

On Mon, Sep 24, 2001 at 11:10:09AM -0500, kfogel@collab.net wrote:
> Ben Collins-Sussman <sussman@collab.net> writes:
> > We do let the user know that the network connection failed; the
> > status output currently prints '?' where the head revision would be.
> > Isn't that enough?
>
> IMHO it doesn't look enough like an error, yet a certifiable error has
> occurred. Instead of "?", a warning line like Bill said would be more
> unmistakable.

Not to mention letting you know *why* it failed, rather than just "it did".

IMO, it should error anyways based on how svn status should work. If status
normally runs locally, then there is no problem. If you *tell* it to talk to
the repository, then it is an error not to.

So this whole "ignore" / warning thing just goes in the dumpster. In
general, ignoring/warning about stuff isn't a good idea.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006

This is an archived mail posted to the Subversion Dev mailing list.