[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: It is time to upgrade to autoconf 2.50 and libtool 1.4.

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-09-22 23:31:19 CEST

On Sat, Sep 22, 2001 at 09:30:51AM -0700, Mo DeJong wrote:
>...
> Bah! Look like I did not test a shared build recently. This patch should
> fix that db linking issue.
>
> Index: ac-helpers/berkeley-db.m4
> ===================================================================
> --- ac-helpers/SVN/text-base/berkeley-db.m4 Mon Sep 10 09:52:38 2001
> +++ ac-helpers/berkeley-db.m4 Sat Sep 22 09:28:54 2001
> @@ -98,9 +98,7 @@
> SVN_DB_INCLUDES="-I$dbdir"
> svn_lib_berkeley_db=yes
> if test "$enable_shared" = "yes"; then
> - # Once we upgrade to libtool 1.4 we should change this to
> - # "$dbdir/libdb-3.3.la"
> - SVN_DB_LIBS="-L$dbdir/.libs -ldb-3.3"
> + SVN_DB_LIBS="-L$dbdir -ldb-3.3"
> else
> SVN_DB_LIBS="-L$dbdir -ldb"
> fi

I fixed it by removing the whole conditional and simply referencing the .la
file. That is the whole point about libtool 1.4 -- you reference .la files
and it actually works during shared builds.

In libtool 1.3, you cannot reference a .la file if there are dynamic libs
specified inside of it. So... we always went into the .libs directory and
implicitly referred to the .so file directly.

In most cases, where we use -L<dir> -l<lib>, it can/should be replaced by a
direct reference to the .la file. Our berkeley-db.m4 file needs updating for
when it searches the system, it should use a .la if it finds it. The code
block you reference above only uses the .la file for an included "db" dir.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006

This is an archived mail posted to the Subversion Dev mailing list.