[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_path_canonicalize

From: Garrett Rooney <rooneg_at_electricjellyfish.net>
Date: 2001-09-20 00:03:49 CEST

On Wed, Sep 19, 2001 at 06:24:37AM -0400, Kevin Pilch-Bisson wrote:
> I haven't really looked at this patch, but I have a question already. There
> are several places where svn_path_canonicalize are called from within other
> parts of the path library. I was thinking we could make url_canonicalize
> private to path.c and make svn_path_canonicalize look like:
> if (style == svn_path_url_style)
> url_canonicalize(path);
> else
> {
> /* Do our non-url canonicalization. */
> }
> This also means nothing outside of path.c has to change.

this isn't completely true...

it appears that we've got several places where we're either passing a
url to svn_path_canonicalize with style = svn_path_repos_style or we're
passing a path to svn_path_canonicalize with style =
svn_path_url_style, so if we're basing our behavior on the style,
we'll have to make this more consistent in the rest of the tree.

garrett rooney                     Unix was not designed to stop you from 
rooneg@electricjellyfish.net       doing stupid things, because that would  
http://electricjellyfish.net/      stop you from doing clever things.
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:42 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.