Re: Patch for error deleting newely added directory.

Mo DeJong <supermo@bayarea.net> writes:

> My solution to this problem was to notice the case where the this_dir
> entry was removed and make a call to svn_wc_remove_from_revision_control
> for the directory that was being "unadded". I also had to check for this
> case in svn_wc_delete to avoid an attempt to delete the parent's entry
> twice.
>
> Does this seem like a reasonable approach? It fixes the bug for me, but
> I wanted to make sure it is "right".

Nope, it's wrong. In fact, it's the *exact* same wrong change that I
checked in a while ago and then reverted (because of its wrongness). :-)

The entries reading/writing interfaces are very low-level, and have no
business making decisions about what is an what isn't under revision
control. Their job is to read/write a hash from/to disk, that's it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:41 2006