[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [SVN-DEV] Re: [PATCH] clean up pre-python 2.1 'make check' output.

From: C. Scott Ananian <cananian_at_lesser-magoo.lcs.mit.edu>
Date: 2001-09-05 23:38:21 CEST

On 5 Sep 2001 cmpilato@collab.net wrote:

> Hmm...some things I don't like about this.
> 1. [SKIPPED] is going straight stderr so it can co-mingle with the
> output of the make check rule. This seems kinda wonky.

This is exactly what is desired:
% make check
Running all tests in run-fs-tests.sh...SUCCESS
Running all tests in run-repos-tests.sh...SUCCESS
Running all tests in basic_tests.py...[SKIPPED] SUCCESS

> 2. [SKIPPED] appears when you run the scripts by hand, too. Skipped?
> Whaddaya mean, "skipped"?

It means the test was skipped; not run. That seems clear to me.
You can have it output [NOT RUN] or some such if you like.

> Should these tests simply FAIL if the wrong Python is detected?

No, because it's not indicating failure; it's indicating that the test was
not able to be run because of python issues. It doesn't indicate that the
SVN build is faulty.

> Or,
> should (does?) our test suite recognize a magic exit value for skipped
> tests? Perhaps 0 is SUCCESS, 1 is FAILED, -1 for SKIPPED -- can this
> even be done?

Perhaps. This is far out of my league, though. I submitted what I
thought was a minimal patch to make the output of 'make check' at least
semi-intelligible when an old Python version is being used. Compare to:
% make check
Running all tests in run-repos-tests.sh...SUCCESS
Running all tests in basic_tests.py...Traceback (innermost last):
  File "basic_tests.py", line 24, in ?
    import svntest
  File "svntest/__init__.py", line 2, in ?
    import main, tree, actions
  File "svntest/actions.py", line 45
     [[x[0], x[1]] for x in main.greek_tree])
 SyntaxError: invalid syntax
Running all tests in commit_tests.py...Traceback (innermost last):

What sense does *that* make? It's reporting success but barfing up
tracebacks on the screen.

Hussein chemical agent non-violent protest Waco, Texas Suharto BATF
Yakima algorithm kibo LA Bejing planning SDI Legion of Doom Nader
              ( http://lesser-magoo.lcs.mit.edu/~cananian )
 "These students are going to have to find out what law and order is
 all about." -- Brig. General Robert Canterbury, Noon, May 4, 1970,
 minutes before his troops shot 13 unarmed Kent State students, killing 4.
#!/usr/bin/perl -w
# 526-byte qrpff, Keith Winstein and Marc Horowitz <sipb-iap-dvd@mit.edu>
# MPEG 2 PS VOB file on stdin -> descrambled output on stdout
# arguments: title key bytes in least to most-significant order

To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:40 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.