Re: [PATCH] clean up pre-python 2.1 'make check' output.

"C. Scott Ananian" <cananian@lesser-magoo.lcs.mit.edu> writes:

> Index: ./trunk/subversion/tests/clients/cmdline/commit_tests.py
> ===================================================================
> --- ./trunk/subversion/tests/clients/cmdline/SVN/text-base/commit_tests.py Wed Sep 5 15:32:24 2001
> +++ ./trunk/subversion/tests/clients/cmdline/commit_tests.py Wed Sep 5 15:53:32 2001
> @@ -23,8 +23,9 @@
> try:
> import svntest
> except SyntaxError:
> + sys.stderr.write('[SKIPPED] ')
> print "<<< Please make sure you have Python 2.1 or better! >>>"
> - traceback.print_exc()
> + traceback.print_exc(None,sys.stdout)
> raise SystemExit

Hmm...some things I don't like about this.

1. [SKIPPED] is going straight stderr so it can co-mingle with the
    output of the make check rule. This seems kinda wonky.

2. [SKIPPED] appears when you run the scripts by hand, too. Skipped?
    Whaddaya mean, "skipped"?

Should these tests simply FAIL if the wrong Python is detected? Or,
should (does?) our test suite recognize a magic exit value for skipped
tests? Perhaps 0 is SUCCESS, 1 is FAILED, -1 for SKIPPED -- can this
even be done?

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:40 2006