Re: CVS update: MODIFIED: svnlook ...

Greg Stein <gstein@lyra.org> writes:
> > + SVN_ERR (svn_repos_open (&(session_baton->fs),
> > + session_baton->repos_path->data,
> > + session_baton->pool));
>
> Note that C operator precedence allows for &session_baton->fs. The parens
> are not necessary.
>
> [ YSCMV... (your stylistic conventions may vary) ]

Thanks for noticing. Although I know intellectually that the
precedence works out right, I usually instinctively read "&foo" as
binding very tightly, and do a double take when I encounter
"&foo->bar".

So I eventually decided to always parenthesize it, just to simplify my
life. :-)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:35 2006