Re: CVS update: MODIFIED: svnlook ...

On Wed, Aug 15, 2001 at 04:48:03PM -0000, cmpilato@tigris.org wrote:
> User: cmpilato
> Date: 01/08/15 09:48:03
>
> Modified: subversion/svnlook main.c
> Added: subversion/libsvn_repos node_tree.c
> Removed: subversion/svnlook editors.c nodetree.c svnlook.h
> Log:
> Moving code that from svnlook into the libsvn_repos library (because
> we plan to make svnadmin use it, too)
>...
> * subversion/libsvn_repos/node_tree.c
>
> New file (with contents + edits from subversion/svnlook/editors.c
> and subversion/svnlook/nodetree.c)

Damn it. How are we to see those edits?

I'll repeat my advice from before: when moving functions or files or
whatever, do it in two parts:

1) move it unchanged, and note that in the log. use a separate commit if you
   want.

2) make the changes. these are then in the commit email for review.

If Karl is all scary about M3 patches, then changes should be reviewable.

-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org