[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: MODIFIED: libsvn_subr ...

From: Greg Stein <gstein_at_lyra.org>
Date: 2001-06-14 11:59:59 CEST

On Thu, Jun 14, 2001 at 09:48:52AM -0000, gstein@tigris.org wrote:
>...
> /* The xml delta we got was not well-formed. */
> SVN_ERRDEF(SVN_ERR_MALFORMED_XML, "XML data was not well-formed")
>
> /* A working copy "descent" crawl came up empty */
> SVN_ERRDEF(SVN_ERR_UNFRUITFUL_DESCENT, "WC descent came up empty")
>
> /* A bogus filename was passed to a routine */
> SVN_ERRDEF(SVN_ERR_BAD_FILENAME, "Bogus filename")
>...

I left the comments in there because I was doing the "brain dead" approach.
I simply copied the string over from the hash table in svn_error.c. I didn't
do any comparison of comment vs. error string.

Many of the comments could be removed, or the error strings enhanced and
expanded (thus obsoleting the need for the comments), etc. If the comment
says more than the error string, then the string may be missing something. I
would think that many of the error codes will be self-description by simple
virtue of the fact that a description is right there with the enum name.

Although... it's quite possible that some errors may still leave a comment
in there, describing *when* to use the error code (while the string
describes a problem to the user).

But that is for a different pass, should we take this approach.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 21 14:36:31 2006

This is an archived mail posted to the Subversion Dev mailing list.