Re: CVS update: MODIFIED: libsvn_subr ...

On Thu, Jun 14, 2001 at 01:58:55AM -0700, Greg Stein wrote:
>...
> > So -- we either need to make svn_strerror a static routine (so that
> > ONLY svn_handle_error can use it), or we need to document that the
> > pool must be top-level pool, or we need
>
> Documenting is a way around the basic problem: if the pool goes away, then
> the hash table gets garbaged. As I mentioned, you could have a cleanup that
> stores a NULL into the static variable. Next time somebody goes for an
> error, the hash table gets rebuilt again, using whatever pool was passed at
> that point in time.

I wanted to clarify my point a bit more here...

Documentation and a pool cleanup are ways to "paper over" (IMO) underlying
problems.

The problems can be avoided altogether by using another approach. (yes, doc
is still desired, but it isn't required to the same degree; the system is
robust even without doc)

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org