[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: WIN32 compability in svn_ra_local__split_URL?

From: Magnus Sirwi´┐Ż <sirwio_at_hotmail.com>
Date: 2001-04-26 17:52:26 CEST

Hi cmpilato and others,

This is what I'm trying to explain.
Lets say I have created a repo in C:\svnroot with
c:\>svnadmin create C:\svnroot

Next I switch to my svn sandbox to import my HelloWorld sources:
c:\svnbox>svn import file://localhost/D:\svnroot . HelloWorld

The REPOS_URL given above, (file://localhost/D:\svnroot), isn't handled
correctly on WIN32. While "splitting" the absoulte path portion of the
REPOS_URL something goes wrong. The absoulte path above will be splitted to
/D:\svnroot which is an invalid filename on WIN32.

The way I patched this was to get rid of the heading / from the absolute
path for WIN32 builds. I'm not sure though if this is the correct way to
solve the problem.

I'm glad to see that eventually WIN32 will be supported. I know by
experiance that its a pain in the butt to keep the WIN32 build up to date
since svn is a moving target. I have managed it and have all subsystems
compilable even though all parts are not working yet. Once you have time I
can contribute fresh patches! Meanwhile I'm learning how e.g. apache has set
up its WIN32 builds.

What's the status of the mod_dav_svn subsystem? I crashing big time on NT
and I can't get it working on my linux box either...

\Magnus - Who's keeping the faith :-)

cmpilato wrote:
>From: cmpilato@collab.net
>"Magnus Sirwi´┐Ż" <sirwio@hotmail.com> writes:
> > I think there are some WIN32 compability issues in function
> > svn_ra_local__split_URL in file split_url.c
> >
> > A file URL will on uni* be something like:
> > file:///svnroot/HelloWorld
> > or with the host specified
> > file://localhost/svnroot/HelloWorld
> >
> > On WIN32 the URL would be:
> > file://localhost/C:\svnroot\HelloWorld
>Hey, Magnus. I'm a touch confused about the above. Are you saying
>that right now, on Win32, the URL *will* look like
>'file://localhost/C:\svnroot\HelloWorld' and shouldn't, or that it
>*should* look like that and currently doesn't?
> > A while ago I submitted some WIN32 patches. Although I know some of them
> > didn't quite follow the submission guidelines they were not that ugly (I
> > would say that some even followed the guidelines).
> >
> > Is there any use submitting WIN32 patches? I'm eager to contribute but
> > nothing gets commited or if no one gives feedback I won't bother to
> > this list any more...
>I'll present an apology to you for this, as I had full intentions of
>reviewing the patches you sent. Unfortunately I got tied up doing
>other things. Right now, I fully expect SVN not to build under Win32
>at all. Files are still getting moved around a bit, and I've not even
>bothered trying to keep Win32 in sync with the rest of the world.
>When next I get a chance to do so, and when I'm near a Win32 box, I
>will try to get your patches reviewed and hopefully integrated.
>However, I must admit that this may not be very soon. The CollabNet
>Three (Karl, Ben, and myself) are moving to a new office this weekend,
>and I'm not sure how long it will take to get everything in at least a
>work-ready state.
>Perhaps Branko or another Win32 user would be so kind as to do a
>little patch review?
>Regardless of that, please forgive us for being less than hospitable.
>Your attention to the Win32 side of things is appreciated, and we
>certainly don't mean to fail in encouraging you in that.

Get Your Private, Free E-mail from MSN Hotmail at http://www.hotmail.com.
Received on Sat Oct 21 14:36:29 2006

This is an archived mail posted to the Subversion Dev mailing list.