[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_wc get_editor.c

From: Ben Collins-Sussman <sussman_at_collab.net>
Date: 2001-04-19 00:13:18 CEST

Greg Stein <gstein@lyra.org> writes:

> On Wed, Apr 18, 2001 at 09:36:12PM -0000, sussman@tigris.org wrote:
> > User: sussman
> > Date: 01/04/18 14:36:12
> >
> > Modified: subversion/libsvn_wc get_editor.c
> > Log:
> > (make_file_baton): duh, initialize wcprop array.
> >
> > (close_file): move wcprop dumping to the end, *after* the log running
> > guarantees that the file already exists.
> While the props aren't versioned, we may want to consider a way to make
> their writing atomic.

It's worse than that; I just discovered today (I *think*) that ever
regular props aren't being written atomically.

I mean, I know that when the update editor receives normal user props,
it stores them (along with new text) in SVN/tmp/, and then a log file
is executed which atomically moves the new text and new props into
text-base/ and prop-base/. But when the user runs plain old "svn
propset foo bar A/mu", there's no atomicity. We read the propfile,
change it in RAM, then write it out again. Oops!

I should put this on my todo list.
Received on Sat Oct 21 14:36:29 2006

This is an archived mail posted to the Subversion Dev mailing list.