[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_client commit.c

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2001-03-09 23:14:41 CET

No comments, just writing to thank Greg publically for the code
review(s)...

-K

Greg Stein <gstein@lyra.org> writes:
> On Fri, Mar 09, 2001 at 10:14:40PM -0000, sussman@tigris.org wrote:
> >...
> > --- commit.c 2001/03/09 21:03:22 1.19
> > +++ commit.c 2001/03/09 22:14:40 1.20
> >...
> > + /* Fetch the xml commit editor. */
> > + SVN_ERR (svn_delta_get_xml_editor (svn_stream_from_aprfile (dst, pool),
> > + &commit_editor, &commit_edit_baton,
> > + pool));
> > +
> > + if (SVN_IS_VALID_REVNUM(revision))
> > + {
> > + /* Fetch tracking editor WITH revision bumping enabled. */
> > + tracking_editor = svn_delta_default_editor (pool);
> > + }
> > + else
> > + {
> > + /* Fetch tracking editor WITHOUT revision bumping enabled. */
> > + tracking_editor = svn_delta_default_editor (pool);
> > + }
>
> Those two branches look the same. Is there supposed to be more code in
> there? It would be nice to use ### or XXX or TODO or something to let people
> know that more work is intended.
>
> [ I have used ### for years; it doesn't occur in any syntax, and it is
> "loud" (e.g. compare against "kff todo") which makes it easy to spot when
> browsing code. ]
>
> In any case, without a marker, it is hard to know whether you considered the
> above code "final" and thus I'm pointing out a problem, or whether you will
> be returning.
>
> Cheers,
> -g
>
> --
> Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:25 2006

This is an archived mail posted to the Subversion Dev mailing list.