[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Check min and max num targets in client args patch.

From: B. W. Fitzpatrick <fitz_at_red-bean.com>
Date: 2001-03-06 19:16:55 CET

> Mo DeJong <mdejong@cygnus.com> writes:
> > I noticed some problems with the way the command line
> > client was checking the user's input before passing
> > commands to the actual function. For example, a
> > call to `svn delete` should notice that at least
> > 1 argument is required and print the help text
> > for the delete subcommand. The current code passed
> > the args to the delete subcommand anyway and that
> > printed the main usage text instead of the delete
> > help text. The following patch fixes the problem
> > by adding a min and max number of targets field
> > to the command struct. Main then checks to see
> > if the number of arguments the user passed
> > satisfies the (0 to N) or (1 to N) requirement.
> > I also have a patch that removes the num
> > targets check in the functions, but that can
> > wait until after this patch.
>
> Wow, perfect. I think Fitz described a plan exactly like this to me
> the other day... and now you've gone and stolen his thunder. :-)
>
> Fitz, another one for your plate. (Let us know if your plate is
> getting too full, though; Franklin can do some of it).

Too full? Naaaaaaaaah. Sleep is for the weak.

:)

-Fitz
Received on Sat Oct 21 14:36:25 2006

This is an archived mail posted to the Subversion Dev mailing list.