Re: CVS update: subversion/subversion/libsvn_fs rev-table.c

Greg Hudson <ghudson@MIT.EDU> writes:

> The point of svn_stream_close is not to free memory. It is to say
> "I'm done {reading/writing} this stream now," which is important for
> things like svndiffs. Our pool management system means that an
> explicit destruction method is not necessary for every data type we
> have, but for some reason we don't seem to all be on the same page
> about that.

Ahhhh, gotcha. Then in the current case of svn_fs_file_contents(),
it's perfectly fine that I've not registered any sort of stream_close
function. The read stream that I'm returning doesn't care when it's
done being read; and as for memory, the both the stream and its
massive baton will be reaped when the original pool is freed.

Cool, thanks for the clarification. Everything is fine.
Received on Sat Oct 21 14:36:25 2006