[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_fs dag.c dag.h

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2001-03-02 22:49:44 CET

Greg Stein <gstein@lyra.org> writes:
> I'm not sure if Mike intended it or not, but we still have the need to open
> a node by ID rather than by revision/path. With this function, tree.c can
> accomplish that task.

Oh ho! I don't _think_ that was the motivation, but maybe Mike was
just way in tune with your needs. Okay, I'll refrain from
depublicizing it, and wait to see Dostoevskian streams of text pass
between you and Jim. :-)

-K

> On Fri, Mar 02, 2001 at 06:46:07PM -0500, Jim Blandy wrote:
> >
> > Why does that function need to be public? This looks very wrong.
> >
> > cmpilato@tigris.org writes:
> >
> > >
> > > User: cmpilato
> > > Date: 01/03/02 12:32:36
> > >
> > > Modified: subversion/libsvn_fs dag.c dag.h
> > > Log:
> > > * libsvn_fs/dag.h
> > > * libsvn_fs/dag.c
> > >
> > > (svn_fs__dag_get_node): Renamed from create_node, and exposed to
> > > other FS module components outside of dag.c.
> >...
> > > --- dag.h 2001/02/27 22:03:46 1.30
> > > +++ dag.h 2001/03/02 20:32:36 1.31
> > > @@ -58,6 +58,15 @@
> > > typedef struct dag_node_t dag_node_t;
> > >
> > >
> > > +/* Allocate (from TRAIL->pool) and return a new dag_node_t structure
> > > + *NODE, initialized with the values ID and FS, and setting
> > > + *NODE->pool to TRAIL->pool. */
> > > +svn_error_t *
> > > +svn_fs__dag_get_node (dag_node_t **node,
> > > + svn_fs_t *fs,
> > > + svn_fs_id_t *id,
> > > + trail_t *trail);
> > > +
> > > /* Return a new dag_node_t object referring to the same node as NODE,
> > > allocated in TRAIL->pool. If you're trying to build a structure in
> > > TRAIL->pool that wants to refer to dag nodes that may have been
>
> --
> Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:25 2006

This is an archived mail posted to the Subversion Dev mailing list.