Re: CVS update: subversion/subversion/include svn_delta.h

Greg Stein <gstein@lyra.org> writes:

> > svn_error_t *apply_string_as_delta (svn_string_t *string
> > svn_txdelta_window_handler_t *handler,
> > void *baton);
> >
> I have a function almost exactly like the above in libsvn_ra_dav/fetch.c.
> Take a look at fetch_file_reader(). It happens to have a baton that carries
> the "handler" and "baton" that GregH quoted above, but passing those
> explicitly is easy. Then, it takes a buffer/length pair and applies that.

Interesting... I may just steal your routine, GregS.

Two questions about it:

  * I notice that you *statically* declare and initialize a window
    struct, and even an svn_string_t. Isn't this a dangerous,
    non-robust practice? :)

  * Your function isn't pushing a 0 after pushing its window. Is that
    being done by the caller? Shouldn't it be done by your func?
Received on Sat Oct 21 14:36:24 2006