[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] svn_fs_revision_prop and friends

From: Yoshiki Hayashi <yoshiki_at_xemacs.org>
Date: 2001-03-01 09:33:47 CET

Ben Collins-Sussman <sussman@newton.ch.collab.net> writes:

> Yoshiki Hayashi <yoshiki@xemacs.org> writes:
> > +/* Return true iff SKEL is an atom whose data is the same as STR. */
> > +int svn_fs__atom_matches_string (skel_t *skel, svn_string_t *str);
> Is this really necessary? Can't you just call
> svn_fs__matches_atom (skel, string->data)
> Remember than svn_string_t's are guaranteed to be null-terminated, so
> you can use them as char *'s effortlessly.

It isn't necessary but it doesn't hurt either. If
string->data is big, saving a call to strlen() might mean
something. If you don't like it, I'll send a new patch
without above change.

Yoshiki Hayashi
Received on Sat Oct 21 14:36:23 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.