I'd rather have you add a new error-creation function to err.[ch] than
take up a lot of space in the function building errors. The
error-construction code is formulaic, and I think it makes the code
less skimmable.
cmpilato@tigris.org writes:
> + if (! svn_fs__dag_is_mutable (parent)) /* is the parent mutable? */
> + {
> + /* return some nasty error */
> + return
> + svn_error_createf
> + (SVN_ERR_FS_NOT_MUTABLE, 0, NULL, trail->pool,
> + "Attempted to clone child of non-mutable node");
> + }
> +
> + /* Find the entry named NAME in PARENT if it exists. */
> + entry_skel = find_dir_entry (parent, name);
> + if (! entry_skel)
> + {
> + /* return some other nasty error */
> + return
> + svn_error_createf
> + (SVN_ERR_FS_NOT_FOUND, 0, NULL, trail->pool,
> + "Attempted to clone non-existant child node");
> + }
Received on Sat Oct 21 14:36:23 2006