Re: CVS update: subversion/subversion/libsvn_delta delta.h xml_output.c xml_parse.c

> Note: some people may wonder why we should use a #define for a
> string because every time we change the string, we gotta go rename
> the #define and later the string anyways (e.g. extra work). Well,
> kiddies... you only have to check for typos once with a #define; raw
> strings leads to all kinds of nasty typos that are a hella-bitch to
> find. With #defines, you get compilation errors instead.

I still think the cost is higher than the benefit. With literal
strings you can see what the thing is, right away. With a
preprocessor symbol you don't even know it's a string.

Are we going to do this every time we generate terminal output as well
as every time we generate XML output?

(And, pet peeve: i.e., not e.g..)

>> Greg Stein, please put on your Namespace Protection Police cap and
>> make sure that new brain I ordered this morning is working better
>> than my old one.

> hehe... looks fine to me. I'm simply interested in sharing what you
> were smoking yesterday :-)

These aren't public symbols. They don't need such annoyingly long names.
Received on Sat Oct 21 14:36:21 2006