Re: condense_targets and basepath functions

On Fri, Feb 09, 2001 at 11:41:09AM -0500, Kevin Pilch-Bisson wrote:
> Ben,
>
> What do think about what Greg/Karl said? Also should the targets string
> be modified in place or a new one returned? Finally, what names would
> like the functions to have? I am thinking:

Careful. He is working on other code right now... Don't distract him :-)

>...[ prototypes ]

I'm thinking it might be nice to go ahead and collapse these into one
function (condense_targets). Further, to make pbasename be required. Then,
we could do:

*) rename it pbasedir to make it obvious it is always a dir
*) targets become *relative* to pbasedir

We could actually make the targets-return-value optional if we wanted.

Having the targets as relative values is a bit nicer. It means that we don't
have to chop them up to remove the absolute portion. When we go to actually
pass the targets to (say) the RA do_update function, we'll also need to
convert them to "URL style". But I believe condense_targets should just use
"local style"... hmm. Maybe a passed-in style?

[ the WC will pass them as local style, but I could see the function being
  used to condense URLs, too ... ]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/