[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Change #1 Considered Harmful

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2001-02-05 21:55:15 CET

Jim Blandy <jimb@zwingli.cygnus.com> writes:
> I guess I think it's weird to have an interface that supports the
> feature of "I decided not to use this interface." Usually, if you're
> not sure you want to perform an operation yet, you just don't perform
> it.

Yeah, I generally agree. Just that in this case, the party that knows
whether or not the operation will be performed is not the same party
who constructs the editor.

> You'd better document the fact that an editor constructor should never
> actually *do* anything, and that all actual work must take place after
> the begin_edit call.

Absolutely (and thanks for the reminder -- I had just finished the
reversion of Change #1 but forgot that we were going to add that
clarifier to the docs).
Received on Sat Oct 21 14:36:21 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.