Re: FreeBSD 4.2 breakage (?)

> I spent a good amount of time trying to figure out the right
> combination to allow us to include <string.h> and <strings.h> (which
> is done by apr_want.h) without some redundant declaration warnings.

Can we change apr_want.h not to include <strings.h> if
APR_HAVE_STRING_H is defined?

> Removing redundant-decl was the easy fix, but I didn't think it was
> the right fix. Removing POSIX_SOURCE is also the easy fix, but I
> don't think the right fix :-)

Well, it is certainly wrong to define _POSIX_SOURCE and then include
<strings.h>, even if it doesn't happen to break anything at the
moment like <sys/socket.h> does.

I notice that apr_file_io.h also drags in <sys/uio.h>, also a
non-POSIX header. Once again, _POSIX_SOURCE is not compatible with
this behavior.
Received on Sat Oct 21 14:36:21 2006