RE: CVS update: subversion/subversion/clients/win32/svn_com SVN.c pp MarshalArray.h

I don't know if proxy objects use shared kernel resources that care whether
or not they get cleaned up in the process crash case.

The comment pretends proxy objects that just talk to other threads in the
same process don't care. The other alternative is to not use ATL's
IConnectionPointImpl class, but I didn't want to take the trouble to do that
either. I just hit my tolerance of pain and decided to work on something
more productive. If we ever need to fix the problem, either solution should
do the trick. (yes, both solutions suck in some way)

Bill

-----Original Message-----
From: Branko Cibej [mailto:brane@xbc.nu]
Sent: Friday, February 02, 2001 11:36 AM
To: dev@subversion.tigris.org
Subject: Re: CVS update: subversion/subversion/clients/win32/svn_com SVN.cpp
MarshalArray.h

rassilon@tigris.org wrote:

> +// BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG BUG
BUG
> +// This class as is returns IMarshal * for IEnumConnectionPoint calls.
> +// This doesn't cause any problems currently.
> +// The only way to fix this is to have a per thread proxy cache.
> +// BUT... This requires catching DLL_THREAD_DETACH in DllMain in order

Forget it, that won't work in general. One of the more marvelous
features of Win32 dynamic linking is that DLL_THREAD_DETACH and
DLL_PROCESS_DETACH don't get sent if a process crashes.

"How an I gonig to clean up shared resources?" Don't ask ... :-(

-- 
Brane Cibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/