On Wed, Jan 31, 2001 at 07:16:30AM -0600, Karl Fogel wrote:
> Kevin Pilch-Bisson <kevin@pilch-bisson.net> writes:
> > I noticed as I was building this morning that since we now have the
> > default editor (thanks all), every test project which has a LDADD of the
> > test_editor, now also needs libsvn_delta. We can fix this one of two
> > ways.
> >
> > 1) Put the @SVN_LIBSVN_DELTA_LIBS@ in the LDADD for each test the uses
> > @SVN_TESTS_EDITOR_LIBS@ in each Makefile.am that needs it or
> >
> > 2) Change the definition of @SVN_TESTS_EDITOR_LIBS@ to automagically
> > include libsvn_delta.la, since it will always be required.
> >
> > What are people's preferences?
>
> The latter would be best, IMHO.
>
Originally, I thought so too, but now I am of two minds. While it would
be nice to just have to put @SVN_TESTS_EDITOR_LIBS@ to get everything
you need. Why does this not apply also to say, @SVN_LIBSVN_DELTA@
including libexpat, libsvn_subr, etc. If we were to go this way, I say
it should then apply to all the @SVN_*@ variables, but if we do this,
then people will probably redundantly put things there, not realizing
that something else will automiatically grab it.
Anyone else?
--
>~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Kevin Pilch-Bisson
kevin@pilch-bisson.net
http://www.pilch-bisson.net
PGP Public Key At http://pgp.pilch-bisson.net
- application/pgp-signature attachment: stored
Received on Sat Oct 21 14:36:20 2006