[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/client diff.c

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2001-01-27 17:48:58 CET

> OK, so why did I have to make this change? I mean, we went through
> all this bother to convert stdout into an apr_file_t, but I'm not
> supposed to apr_close() it when I'm done?

I'm certainly not surprised; when you fdopen() a file descriptor, the
resulting file handle "owns" the file descriptor and will close it
when you fclose() the file handle. Same with APR and
apr_put_os_file() or whatever it's called.

This would be cleaner if apr_create_process had a better interface for
"leave stdout alone." (Assuming it doesn't... if I recall correctly,
you said that if outfile was NULL then stdout went nowhere.)
Received on Sat Oct 21 14:36:20 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.