OK, so why did I have to make this change? I mean, we went through
all this bother to convert stdout into an apr_file_t, but I'm not
supposed to apr_close() it when I'm done?
I noticed this weirdness when I specified multiple targets to diff;
only the first diff would display -- because apparently the
"apr_close()" of stdout would somehow shut off the stream for all the
remaining diff calls.
I'm just wondering if this is a bug or a feature. :)
sussman@tigris.org writes:
> User: sussman
> Date: 01/01/26 11:40:49
>
> Modified: subversion/client diff.c
> Log:
> (svn_cl__print_file_diff): stop apr_closing the handle which
> represents stdout. This was preventing us from printing out diffs for
> more than one file on the commandline.
>
> Revision Changes Path
> 1.5 +0 -2 subversion/subversion/client/diff.c
>
> Index: diff.c
> ===================================================================
> RCS file: /cvs/subversion/subversion/client/diff.c,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- diff.c 2001/01/26 19:15:18 1.4
> +++ diff.c 2001/01/26 19:40:48 1.5
> @@ -69,8 +69,6 @@
> NULL, outhandle, NULL, pool);
> if (err) return err;
>
> - apr_close (outhandle);
> -
> /* TODO: someday we'll need to worry about two things here:
>
> 1. svn_client_file_diff may be returning a file from RA instead
>
>
>
Received on Sat Oct 21 14:36:20 2006