[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_fs txn-table.c

From: Branko Čibej <brane_at_xbc.nu>
Date: 2001-01-25 05:19:14 CET

jimb@tigris.org wrote:

> User: jimb
> Date: 01/01/24 14:13:28
> Modified: subversion/libsvn_fs txn-table.c
> Log:
> * libsvn_fs/txn-table.c (svn_fs__get_txn_list): Don't set *NAMES_P
> until we know the operation has succeeded.


> - (*names_p)[names_count++] = apr_pstrndup (pool, key.data, key.size);
> + names[names_count++] = key.data;

You didn't run fs-test before checking this in, by any chance? key.data
isn't null-terminated, so you get garbage at the end of the transaction
ID. That's why I copied out the key.

If you really think it's worth the trouble to save space/cycles here, we
could do some magic about how we set up the DBT's buffer. For myself I
think it's just not worth the trouble right now.

Brane �ibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/
Received on Sat Oct 21 14:36:19 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.