[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Patch for supporting VPATH builds

From: Branko Čibej <brane_at_xbc.nu>
Date: 2001-01-25 04:42:47 CET

Greg Stein wrote:

> On Thu, Jan 25, 2001 at 12:30:20AM +0100, Branko Cibej wrote:
>
>> Kevin Pilch-Bisson wrote:
>>
>>>> you sure this is right? APR uses mkdir.sh from apr/helpers. I think
>>>> we should do the same.
>>>
>>> We could, I was just looking at the GNU Makefile conventions, and it
>>> said mkdir was one of the utilities we could expect all platforms to
>>> have, thus we could use it directly. However, automake generates some
>>> stuff which relies on $MKDIR, so I just set it to mkdir.
>>
>> APR's script creates the whole path, like "mkdir -p".
>>
>> Anyway, leave it in; we can fix it if it turns out to be broken.
>
>
> The script is needed because "mkdir -p" is not portable. The MKDIR
> assignment *should* use apr/helpers/mkdir.sh

I put that in, along with some more changes to configure.in: I moved the
new defines around a bit, fixed the include path for APRVARS and did
away with the shell escapes.

Oh, and the library order was reversed in
libsvn_subre/tests/Makefile.am, causing the link to fail.

Everything except Neon (and therefore svn_ra_dav) now compiles with
builddir != srcdir, and make check also works.

(But note that it doesn't pass, the last libsvn_fs test fails. Have to
look into that.)

-- 
Brane �ibej
    home:   <brane_at_xbc.nu>             http://www.xbc.nu/brane/
    work:   <branko.cibej_at_hermes.si>   http://www.hermes-softlab.com/
     ACM:   <brane_at_acm.org>            http://www.acm.org/
Received on Sat Oct 21 14:36:19 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.