[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "path" during a commit walk

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-12-30 01:39:03 CET

On Fri, Dec 29, 2000 at 07:08:34PM -0500, Greg Hudson wrote:
> I'm responding to the 18 Dec 2000 message where Greg Stein originally
> presented the properties issue.
>
> > We can't really do it as part of the get_commit_editor() because a
> > single editor may be used multiple times (e.g. replace_root called
> > many times) with different roots.
>
> Is that really allowed in our contract?

replace_root/close_directory pairs appear to be legal.

> Greg Stein wrote, in his original presentation
> > Hrm. I'm not sure that I like this because it means that the commit
> > editor would "know" that the handle belongs to the WC. i.e. it loses
> > its interchangeable nature.
>
> Well, the ra_dav commit editor can't function (efficiently) with just
> the information presented by the editor interface.

True. We could probably recover the version resource URL and certainly the
activity collection. But that would be a bunch of round trips to do so.

> > The "real" solution would be:
>
> > [Callbacks to get/set properties in the editor interface]
>
> I would say the right time to introduce this machinery is when we have
> something other than libsvn_wc that stores local properties. For now,
> it's probably best to let the commit editor assume it's being driven
> by libsvn_wc.

Even with this choice, we have a problem. The WC functions to get/set
properties take a filesystem path. That path is not part of the editor
interface.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:18 2006

This is an archived mail posted to the Subversion Dev mailing list.