[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: "path" during a commit walk

From: Greg Hudson <ghudson_at_mit.edu>
Date: 2000-12-30 01:08:34 CET

I'm responding to the 18 Dec 2000 message where Greg Stein originally
presented the properties issue.

> We can't really do it as part of the get_commit_editor() because a
> single editor may be used multiple times (e.g. replace_root called
> many times) with different roots.

Is that really allowed in our contract?

Greg Stein wrote, in his original presentation
> Hrm. I'm not sure that I like this because it means that the commit
> editor would "know" that the handle belongs to the WC. i.e. it loses
> its interchangeable nature.

Well, the ra_dav commit editor can't function (efficiently) with just
the information presented by the editor interface.

> The "real" solution would be:

> [Callbacks to get/set properties in the editor interface]

I would say the right time to introduce this machinery is when we have
something other than libsvn_wc that stores local properties. For now,
it's probably best to let the commit editor assume it's being driven
by libsvn_wc.
Received on Sat Oct 21 14:36:18 2006

This is an archived mail posted to the Subversion Dev mailing list.