[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_wc/tests checkout-test.c

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-12-29 11:02:13 CET

I think one of the biggest benefits to the new stream stuff is reduced
duplication. This patch alone took out three read functions. Good stuff!

Cheers,
-g

On Sat, Dec 23, 2000 at 10:24:51PM -0000, ghudson@tigris.org wrote:
> User: ghudson
> Date: 00/12/23 14:24:51
>
> Modified: subversion/include svn_delta.h
> subversion/libsvn_client apply_edits.c
> subversion/libsvn_delta xml_parse.c
> subversion/libsvn_delta/tests deltaparse-test.c
> subversion/libsvn_wc/tests checkout-test.c
> Log:
> (svn_delta_xml_auto_parse): Use generic stream for input. All callers
> changed.
>...
> --- apply_edits.c 2000/11/26 15:13:12 1.8
> +++ apply_edits.c 2000/12/23 22:24:50 1.9
> @@ -32,30 +32,11 @@
> /*** Helpers ***/
>
> static svn_error_t *
> -generic_read (void *baton, char *buffer, apr_size_t *len, apr_pool_t *pool)
> -{
>...
> --- deltaparse-test.c 2000/11/26 15:13:12 1.59
> +++ deltaparse-test.c 2000/12/23 22:24:51 1.60
> @@ -27,45 +27,13 @@
>
>
>
> -/* An official subversion "read" routine, comforming to POSIX standards.
> - This one reads our XML filehandle, passed in as our baton. */
> -static svn_error_t *
> -my_read_func (void *baton, char *buffer, apr_size_t *len, apr_pool_t *pool)
> -{
>...
> --- checkout-test.c 2000/11/26 15:13:14 1.36
> +++ checkout-test.c 2000/12/23 22:24:51 1.37
> @@ -32,26 +32,7 @@
>
>
> static svn_error_t *
> -test_read_fn (void *baton, char *buffer, apr_size_t *len, apr_pool_t *pool)
> -{
>...

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:18 2006

This is an archived mail posted to the Subversion Dev mailing list.