[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: some APR brokenness, I think

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-10-17 05:32:55 CEST

I found the problem. In a recent revamping of how symbols are
exported/imported from APR and the various Apache submodules, an "extern"
was dropped off of the declarations of those variables in apr_time.h.

I'll get it sorted out and fixed up. Tonite, or tomorrow at the latest. I
saw your temporary "fix", so a delay until tomorrow seems allowable
[ I'm also working on a mod_dav 1.0.2 release tonite ]

Cheers,
-g

On Mon, Oct 16, 2000 at 03:13:58PM -0500, Karl Fogel wrote:
> It looks like there's some problem with how apr_day_snames[] and
> apr_month_snames[] are getting declared now. They used to be arrays
> of fixed-length strings -- each string was three letters and a
> terminating null, such as "Mon", "Tue", "Wed", etc, and "Jan", "Feb",
> "Mar", etc.
>
> Now they are arrays of fixed-length strings whose every byte is
> '\0'. This is probably not the change someone intended. :-)
>
> I thought maybe I was corrupting memory somewhere, but it doesn't look
> like it, because the arrays already toast as of entry to main(). Have
> looked over recent changes to APR, but don't see anything offhand that
> would be causing this.
>
> Greg, can you take a look, or forward this report to whoever maintains
> the time code? Thanks.
>
> cd subversion/libsvn_wc/tests
> gdb checkout-test
>
> (gdb) break main
> Breakpoint 6 at 0x8049566: file checkout-test.c, line 122.
> (gdb) run checkout-1.delta foo_dir
> [...]
> Breakpoint 6, main (argc=3, argv=0xbffff984) at checkout-test.c:122
> (gdb) p apr_day_snames
> $34 = {"\000\000\000", "\000\000\000", "\000\000\000", "\000\000\000",
> "\000\000\000", "\000\000\000", "\000\000\000"}
> (gdb) p apr_month_snames
> $35 = {"\000\000\000" <repeats 12 times>}
> (gdb) quit
> The program is running. Exit anyway? (y or n) y
> Linux thread target has restored Unknown signal handling
> Linux thread target has restored Unknown signal handling
>
> Debugger finished

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:11 2006

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.