[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] add pool pointer to svn_string_t

From: Ben Collins-Sussman <sussman_at_newton.collab.net>
Date: 2000-10-12 18:35:40 CEST

So Greg, you're arguing we toss svn_string_t and use "(const char *) +
pools" as a substitute wherever we can. It seems that your points

        1. We're hardly using svn_string_t's buffering features

        2. Where we *do* use it, it would be cleaner, simpler code
            just to create a new (char *) by reallocing from a pool

        3. Where we need actual variable length "byte" strings
            (rather than C strings), use an svn_buffer_t.

These seem like reasonable ideas, but I'd like to ponder them. What
you are advocating is *not* a trivial thing -- it would take quite a
while to go through all the code and make these cleanups... definitely
a post-milestone-1 thing.
Received on Sat Oct 21 14:36:10 2006

This is an archived mail posted to the Subversion Dev mailing list.