Re: [PATCH] add pool pointer to svn_string_t

On Thu, Oct 12, 2000 at 01:09:38AM -0400, Greg Hudson wrote:
> > IMO, we should switch to passing "const char *" more often.
>
> Assuming we are careful to also pass an associated length when
> necessary, sure. (I don't think it's necessary in most of the places
> where we pass strings.)

We rarely use the length. Most of the time, we simply assume null-term. Yes,
counted strings are "neat", but we don't use that feature much at all.

> > Where we need the buffering features of svn_string, we should use a
> > new svn_buffer type (stripped down from today's svn_string).
>
> What would you strip out of svn_string_t? There isn't much there.

I meant svn_string.c. If the focus is "accumulate bytes" rather than a
generic string type, then some of that stuff disappears. Finding chars (just
use strchr), filling characters (use memset), the "empty" stuff, etc.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/