[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_fs/tests skel-test.c

From: Jim Blandy <jimb_at_savonarola.red-bean.com>
Date: 2000-10-08 19:40:49 CEST

> > DBT *
> > svn_fs__track_dbt (DBT *dbt, apr_pool_t *pool)
> > {
> > if (dbt->data)
> > apr_register_cleanup (pool, dbt->data, apr_free_cleanup, 0);
> >
> > return dbt;
> > }
>
> You should use apr_null_cleanup rather than NULL.

Done --- thanks.

It looks to me like most calls to apr_register_cleanup are just going
to pass apr_null_cleanup as the exec handler. Rather than having a
useless argument in every call, wouldn't it be better to use a
separate function for registering exec cleanups?
Received on Sat Oct 21 14:36:10 2006

This is an archived mail posted to the Subversion Dev mailing list.