Re: CVS update: subversion/subversion/libsvn_fs/tests skel-test.c

Greg Stein <gstein@lyra.org> writes:

> On Fri, Oct 06, 2000 at 06:04:40PM -0000, jimb@tigris.org wrote:
> >...
> > + svn_fs_kill_cleanup_node (c->pool, new);
> > + svn_fs_close_node (new);
>
> Take a look at apr_run_cleanup(). It will run the cleanup and kill it in one
> fell swoop.

At the moment, I'm providing functions like this:

/* Request a cleanup. */
void svn_fs_cleanup_node (apr_pool_t *pool, svn_fs_node_t *node);
/* Cancel a cleanup. */
void svn_fs_kill_cleanup_node (apr_pool_t *pool, svn_fs_node_t *node);

Basically, this hides the cleanup function itself from the caller.
I'm not sure it's worth it.

Would you prefer that the fs simply export a function suitable for use
as an APR cleanup, and then let user register, kill, or run it as they
please?

Whichever way you like, I'll do.
Received on Sat Oct 21 14:36:10 2006