[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

From: Greg Hudson <ghudson_at_MIT.EDU>
Date: 2000-10-05 19:30:12 CEST

An aside to something you said earlier: I have things like
</dir></replace> on the same line because I feel like add/replace and
dir/file make up a single logical unit, even though they're separate
elements. Since dirent prop deltas are gone, an add/replace element
consts of a file/dir element and nothing else.

> Greg, looking over the code, I'm wondering if maybe you don't want
> to use functions like

Er, sorry, yes, it was a little rude of me to ignore that work. I
noticed the functions but in the confusion of all the other issues I
wound up just bypassing them to make my life easier.

Here is my main issue: every time we actually perform output, there is
a possible exceptional. Checking for an error after every tag would
make my code a lot more complicated any ugly. That's why my editor
calls compute a string and output it all at the end. So instead of
svn_xml_write_tag_hash (), I would prefer a function which returns a
tag as a string, or one which appends a tag to an existing string.

It appears svn_xml_write_* is used by libsvn_wc already, so changing
the interface would require a bunch of changes to libsvn_wc as well.

A related issue is that I made the XML editor take a generic output
function instead of an apr_file_t *; I could revert that but it seems
like the flexibility is valuble. Given that change, I can't use the
current svn_xml_write_* interfaces since they take an apr_file_t *.
Received on Sat Oct 21 14:36:10 2006

This is an archived mail posted to the Subversion Dev mailing list.