[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_delta xml_output.c

From: Karl Fogel <kfogel_at_galois.collab.net>
Date: 2000-10-05 20:36:28 CEST

Greg Hudson <ghudson@MIT.EDU> writes:
> Here is my main issue: every time we actually perform output, there is
> a possible exceptional. Checking for an error after every tag would
> make my code a lot more complicated any ugly. That's why my editor
> calls compute a string and output it all at the end. So instead of
> svn_xml_write_tag_hash (), I would prefer a function which returns a
> tag as a string, or one which appends a tag to an existing string.
>
> It appears svn_xml_write_* is used by libsvn_wc already, so changing
> the interface would require a bunch of changes to libsvn_wc as well.
>
> A related issue is that I made the XML editor take a generic output
> function instead of an apr_file_t *; I could revert that but it seems
> like the flexibility is valuble. Given that change, I can't use the
> current svn_xml_write_* interfaces since they take an apr_file_t *.

If we changed the svn_xml_write_tag_* functions to svn_xml_make_tag_*
(which would just return strings, instead of outputting them
anywhere), then it would still be useful to both of us.

I'm all for it, and would be happy to change the wc library to use a
string-based interface. Would you be willing to turn those functions
into string creators? I'll update libsvn_wc.
Received on Sat Oct 21 14:36:10 2006

This is an archived mail posted to the Subversion Dev mailing list.