[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: CVS update: subversion/subversion/libsvn_delta/tests Makefile.am

From: Greg Stein <gstein_at_lyra.org>
Date: 2000-09-26 15:58:19 CEST

[ sorry, short reply for now... (still away from home) ]

On Mon, Sep 25, 2000 at 04:19:37PM +0200, Branko Cibej wrote:
>...
> Right now only threading falls into (3), and APR does a very good job of
> finding the right combination of options (IIRC, it's not limited to using
> pthreads, which may be a good thing). So APR's tests should either be
> factored out into a separate acinclude file and reused by the top-level
> configure, or APR's configure should export THREAD_CFLAGS for use by the
> other modules.
>
> (I see you already included apr_common.m4 into the top-level configure.
> Although the threading stuff is not complete there, I feel that's the
> right solution -- especially if we can share config.cache between
> modules so that we don't have to repeat those tests.)

APR should export the flags. We should not attempt to use the same autoconf
macros and hope for the same results. For example, the APR stuff is *not*
all in apr_common.m4 as you point out. It is also in hints.m4 at least, and
there is probably a bit in configure.in.

Exporting the final flags ensures that we have exactly the same flags as
APR. If we just export the macros, then we can only hope that APR uses them
in the same way and doesn't tweak the results (i.e. using hints.m4).

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/
Received on Sat Oct 21 14:36:09 2006

This is an archived mail posted to the Subversion Dev mailing list.