Thanks for spotting this -- wanna patch it? :-)
(Not being facetious -- just letting you know there's no
territoriality here. If I commit something bogus, go ahead and
unbogitify it, unless you think I should do it either because I'll do
it faster, or because I made the mess and I should clean it up. :-) ).
-K
Greg Hudson <ghudson@MIT.EDU> writes:
> Karl committed:
> > -CFLAGS = -pthread
> > +CFLAGS = @CFLAGS@ -pthread
>
> This is better, but still wrong according to the gnu makefile
> standards; I've included the relevant fragment below. Similarly,
> aclocal.m4 macros are not supposed to stuff required flags into the
> CFLAGS environment variable.
>
> ---
>
> If there are C compiler options that *must* be used for proper
> compilation of certain files, do not include them in `CFLAGS'. Users
> expect to be able to specify `CFLAGS' freely themselves. Instead,
> arrange to pass the necessary options to the C compiler independently
> of `CFLAGS', by writing them explicitly in the compilation commands or
> by defining an implicit rule, like this:
>
> CFLAGS = -g
> ALL_CFLAGS = -I. $(CFLAGS)
> .c.o:
> $(CC) -c $(CPPFLAGS) $(ALL_CFLAGS) $<
>
> Do include the `-g' option in `CFLAGS', because that is not
> *required* for proper compilation. You can consider it a default that
> is only recommended. If the package is set up so that it is compiled
> with GCC by default, then you might as well include `-O' in the default
> value of `CFLAGS' as well.
Received on Sat Oct 21 14:36:08 2006