[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in script for differencing docx files

From: Stefan Küng <tortoisesvn_at_gmail.com>
Date: Thu, 11 Apr 2013 19:27:46 +0200

On 10.04.2013 22:42, Ben Fritz wrote:
> On Tue, Apr 9, 2013 at 2:27 PM, BladeOfLight16 <bladeoflight16_at_gmail.com> wrote:
>> I believe I've found a bug in the diff-doc.js script (located at C:\Program
>> Files\TortoiseSVN\Diff-Scripts\diff-doc.js on my machine), used to launch MS
>> Word or OpenOffice as a differencing tool for docx files (among other file
>> types, I imagine). Today, I started receiving an error dialog telling me
>> that I must have MS Word or OpenOffice installed when I tried to do a
>> difference on a docx file. I most definitely have MS Word 2010 installed
>> properly. I did some digging and believe I traced the error to line 66:
>>
>> if(parseInt(word.Version) >= vOffice2013)
>>
>> I believe the variable vOffice2013 is undefined, as adding the following
>> line immediately following the definition of vOffice2007 (line 24) fixed my
>> issue:
>>
>> var vOffice2013 = 15;
>>
>> It is interesting to note that there is also no definition for a 2010
>> version variable (which I believe to be 14), either. Furthermore, it seems
>> strange to me that the check against vOffice2013 occurs inside the try/catch
>> block when it appears that other, similar version checking code is placed
>> outside the try/catch block (see line 130).
>>
>> I am not certain, but I believe that the change related to this post may be
>> the source of the bug:
>> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2872557.
>>
>>
>
> I can confirm the same issue for Word 2010, and the same fix works to
> allow diffing Word documents. I.e., adding the line "var vOffice2010 =
> 14;" makes the problem go away.
>
> I don't see any response to this message, has a bug been filed?

No, but fixed already.

-- 
        ___
   oo  // \\      "De Chelonian Mobile"
  (_,\/ \_/ \     TortoiseSVN
    \ \_/_\_/>    The coolest interface to (Sub)version control
    /_/   \_\     http://tortoisesvn.net
------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3053072
To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-04-11 19:27:54 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.