[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Bug in script for differencing docx files

From: Ben Fritz <fritzophrenic_at_gmail.com>
Date: Wed, 10 Apr 2013 15:42:56 -0500

On Tue, Apr 9, 2013 at 2:27 PM, BladeOfLight16 <bladeoflight16_at_gmail.com> wrote:
> I believe I've found a bug in the diff-doc.js script (located at C:\Program
> Files\TortoiseSVN\Diff-Scripts\diff-doc.js on my machine), used to launch MS
> Word or OpenOffice as a differencing tool for docx files (among other file
> types, I imagine). Today, I started receiving an error dialog telling me
> that I must have MS Word or OpenOffice installed when I tried to do a
> difference on a docx file. I most definitely have MS Word 2010 installed
> properly. I did some digging and believe I traced the error to line 66:
>
> if(parseInt(word.Version) >= vOffice2013)
>
> I believe the variable vOffice2013 is undefined, as adding the following
> line immediately following the definition of vOffice2007 (line 24) fixed my
> issue:
>
> var vOffice2013 = 15;
>
> It is interesting to note that there is also no definition for a 2010
> version variable (which I believe to be 14), either. Furthermore, it seems
> strange to me that the check against vOffice2013 occurs inside the try/catch
> block when it appears that other, similar version checking code is placed
> outside the try/catch block (see line 130).
>
> I am not certain, but I believe that the change related to this post may be
> the source of the bug:
> http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=2872557.
>
>

I can confirm the same issue for Word 2010, and the same fix works to
allow diffing Word documents. I.e., adding the line "var vOffice2010 =
14;" makes the problem go away.

I don't see any response to this message, has a bug been filed?

I'm using TortoiseSVN with the following info in the About dialog:

TortoiseSVN 1.7.12, Build 24070 - 64 Bit , 2013/03/29 08:00:43
Subversion 1.7.9,
apr 1.4.6
apr-utils 1.3.12
neon 0.29.6
OpenSSL 1.0.1e 11 Feb 2013
zlib 1.2.7

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3052979

To unsubscribe from this discussion, e-mail: [users-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2013-04-10 22:43:22 CEST

This is an archived mail posted to the TortoiseSVN Users mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.