Suspicious code in SciEdit

Hey.

Currently CSciEdit::MarkEnteredBugID() has a

for (tr1::sregex_iterator it(s.begin(), s.end(), regCheck, start_pos != 0 ? tr1::regex_constants::match_not_bol : tr1::regex_constants::match_default); it != end; ++it)

loop which iteration starts with

pos = (LONG)it->position(0);

and then near the end of iteration there's this assignment:

pos = (LONG)(it->position(0) + matchedString.size());

Now "pos" value is never used in between. It makes no sense to assign the value twice. Something is wrong here. Could you please address it?

Best wishes.
Dmitry.

------------------------------------------------------
http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=757&dsMessageId=2835610

To unsubscribe from this discussion, e-mail: [dev-unsubscribe_at_tortoisesvn.tigris.org].
Received on 2011-09-05 14:46:56 CEST